[ssjwizard]

Hey guys its me again. Im in the middle of writing a class that can do a crapload of manipulation of arrays of strings. Ive got all of my code working great except for this one last tidbit.

I need to be able to take a user input string search the array and store any names found to be matching. The list is in the format of Last, First. For some reason I just cant get this bit to return any results ever. Ive tried casting the positions as int and that did not make a difference.

Code:

bool NameSearch::findFirstNames(vector <string> &vsFirst, string name){
	size_t found;
	bool find=false;
	for (int i=0;i<total;i++){
		found=names[i].find(name);
		if (found!=string::npos && found>names[i].find(",")){
			vsFirst.push_back(names[i]);
			find=true;
		}
	}
	return find;
}

bool NameSearch::findLastNames(vector<string> &vsLast, string name){
	size_t found;
	bool find=false;
	for (int i=0;i<total;i++){
		found=names[i].find(name);
		if (found!=string::npos && found<names[i].find(",")){
			vsLast.push_back(names[i]);
			find=true;
		}
	}
	return find;
}

Thanks for taking the time to look over this!

[I.M.O.G.]

Free ...Get anywhere on your own yet? I'm sure theres other C++ guys around here

I don't know jack about C++ unfortunately, did a little bit of C# in my younger years, but its long since forgotten.

[Quigsby]

In

Code:

for (int i=0;i<total;i++){

Where is "total" being set?

[pcarini]

I'm pretty sure that Quigsby is right on and 'total' isn't correct. Try replacing your for statements above with the following (This is assuming, of course, that 'names' is a vector<string> type class member.):

Code:

for(int i=0;i<names.size();i++)

It may not be as efficient as tracking the size yourself (it won't be much less efficient, though) but it is a lot more foolproof

This worked for me for testing.. bad code, but OK for a test:

Code:

#include <cstdio>
#include <iostream>
#include <string>
#include <vector>
using namespace std;

class NameSearch
{
	public:
		vector<string> names;

		void add(const string& name) { names.push_back(name); }

		bool findLastNames(vector<string> &vsLast, string name){
			size_t found;
			size_t total = names.size();
			bool find=false;
			for (int i=0;i<total;i++){
				found=names[i].find(name);
				if (found!=string::npos && found<names[i].find(",")){
					vsLast.push_back(names[i]);
					find=true;
				}
			}
			return find;
		}
};

int _tmain(int argc, _TCHAR* argv[])
{
	NameSearch ns;
	vector<string> found_last;

	ns.add("Test, Timmy");
	ns.add("Doe, John");
	ns.add("Doe, Jane");

	bool found = ns.findLastNames(found_last, "Test");
	if( found )
	{
		std::cout << "Name(s) found\n";
		for( size_t i=0; i<found_last.size(); i++)
			std::cout << found_last[i] << "\n";
	}
	else
		std::cout << "No name(s) found\n";

	std::cout << "Press any key\n";
	return 0;
}
/*
Name(s) found
Test, Timmy
*/

[ssjwizard]

total was set from the readfile method, names was a preexisting array I had to work with. I figured out my issue though. The data was in all caps so I just wrote a quick upcase function to ensure the user doesnt mess that up.